Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 319983004: Add missing tests to win_chromium_x64_rel (Closed)

Created:
6 years, 6 months ago by Sergey Berezin
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing tests to win_chromium_x64_rel Was a blocker on a P0 bug, http://crbug.com/380709, but not anymore. After the tryserver split, the blacklisting doesn't trigger, so it is a no-op change. Consider it a cleanup. R=phajdan.jr@chromium.org,stip@chromium.org BUG=225464 TEST=git cl try -m tryserver.chromium.win -b win_chromium_x64_rel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288368

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M testing/buildbot/chromium_trybot.json View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Sergey Berezin
PTAL
6 years, 6 months ago (2014-06-06 23:49:05 UTC) #1
ghost stip (do not use)
lgtm
6 years, 6 months ago (2014-06-07 00:21:20 UTC) #2
Sergey Berezin
Please do NOT commit, see the bug. I'm running more tests to estimate the capacity, ...
6 years, 6 months ago (2014-06-07 01:40:57 UTC) #3
ghost stip (do not use)
bummer :/
6 years, 6 months ago (2014-06-09 18:19:07 UTC) #4
Sergey Berezin
This CL is effectively a no-op now, see http://crbug.com/225464#c23 Will run one more test after ...
6 years, 4 months ago (2014-08-07 18:11:31 UTC) #5
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 4 months ago (2014-08-07 22:26:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/319983004/20001
6 years, 4 months ago (2014-08-07 23:01:40 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 00:59:55 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 01:11:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/2765)
6 years, 4 months ago (2014-08-08 01:12:00 UTC) #10
Paweł Hajdan Jr.
Please update the CL description. This is now a no-op after tryserver split, so it's ...
6 years, 4 months ago (2014-08-08 08:40:11 UTC) #11
Sergey Berezin
Updated description, PTAL. If you stamp it, please also CQ.
6 years, 4 months ago (2014-08-08 15:41:01 UTC) #12
Paweł Hajdan Jr.
LGTM, thanks!
6 years, 4 months ago (2014-08-08 15:47:41 UTC) #13
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 4 months ago (2014-08-08 15:47:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/319983004/20001
6 years, 4 months ago (2014-08-08 15:48:51 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 15:54:21 UTC) #16
Message was sent while issue was closed.
Change committed as 288368

Powered by Google App Engine
This is Rietveld 408576698