Work on blink GN bindings

Work on blink GN bindings.

This makes the bindings basically run although not all of core links so there may be some items left to do.

R=nbarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175913

[Nils Barth (inactive), 2014-06-10 08:44:18]

LGTM with nits.

One meaningful typo: dropped a "_v8" in a GYP file which probably breaks the GYP
build.

Comments generally "FIXME please, so we can decruft later";
also lint seems to miss lots of trailing newlines.

If generated bindings files are the same, I'm fine with however the GN is
structured, and it looks good in any case.

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/BUILD.gn
File Source/bindings/BUILD.gn (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/BUILD.gn...
Source/bindings/BUILD.gn:51: "--write-file-only-if-changed=1",  # Always true
for Ninja.
Could you add a FIXME to remove this cruft once switched to GN?

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/idl...
File Source/bindings/core/idl.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/idl...
Source/bindings/core/idl.gni:33: # Static IDL files / Generated IDL files
This distinction goes away in GN, since we *do* know build dir.
Could you add a FIXME to decruft this once GYP is gone?

(Alternatively, could actually just merge the lists right now,
but then we're departing from GYP and it's more fragile.)

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/idl...
Source/bindings/core/idl.gni:53: 
Nit: trailing newline
(does lint catch this?)

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/v8/...
File Source/bindings/core/v8/generated.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/v8/...
Source/bindings/core/v8/generated.gni:36: 
nit

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/v8/...
File Source/bindings/core/v8/generated.gyp (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/core/v8/...
Source/bindings/core/v8/generated.gyp:101: 'target_name':
'bindings_core_generated_aggregate',
oops: dropped the _v8, which breaks this

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/modules/...
File Source/bindings/modules/BUILD.gn (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/modules/...
Source/bindings/modules/BUILD.gn:22: # GYP verison: event_interfaces action in
bindings_modules_generated
typo: ^verison^version

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/modules/...
File Source/bindings/modules/idl.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/modules/...
Source/bindings/modules/idl.gni:17: # Static IDL files / Generated IDL files
Same comment about this distinction not being necessary in GN

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/modules/...
File Source/bindings/modules/v8/generated.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/modules/...
Source/bindings/modules/v8/generated.gni:36: 
nit

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/scripts/...
File Source/bindings/scripts/scripts.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/scripts.gni:33: # not necessary in the GN build and
could be combined into a single "sources".
Could you add a FIXME for this?

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/scripts/...
Source/bindings/scripts/scripts.gni:199: 
nit

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/template...
File Source/bindings/templates/templates.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/bindings/template...
Source/bindings/templates/templates.gni:18: 
nit

https://codereview.chromium.org/319983003/diff/50001/Source/core/core.gni
File Source/core/core.gni (right):

https://codereview.chromium.org/319983003/diff/50001/Source/core/core.gni#new...
Source/core/core.gni:7: # This file is gn GN version of core.gypi. We rebase
most paths to be absolute
gn GN?

[brettw, 2014-06-10 19:23:52]

Committed patchset #6 manually as r175913.