Issue 319973002: Revert of Push API: define push event on Service Worker.

Issue 319973002: Revert of Push API: define push event on Service Worker. (Closed)

Created:
6 years, 6 months ago by Michael van Ouwerkerk

Modified:
6 years, 6 months ago

Reviewers:
michaeln, Peter Beverloo, jochen (gone - plz use gerrit), dominicc (has gone to gerrit), kinuko

CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, kinuko, falken, dglazkov+blink, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Revert of Push API: define push event on Service Worker. (https://codereview.chromium.org/285403002/) Reason for revert: Broke all builds: http://build.chromium.org/p/chromium.webkit/console e.g. http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Builder/builds/51757/steps/compile/logs/stdio TBR=jochen@chromium.org NOTREECHECKS=true NOTRY=true Original issue's description: > Push API: define push event on Service Worker. > > BUG=350394 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175652 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175653

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -4 lines)			Patch
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/events/EventTypeNames.in	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/modules.gypi	View	1	4 chunks	+6 lines, -0 lines	0 comments	Download
A	Source/modules/push_messaging/PushEvent.h	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
A	Source/modules/push_messaging/PushEvent.cpp	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A +	Source/modules/push_messaging/PushEvent.idl	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
A	Source/modules/push_messaging/ServiceWorkerGlobalScopePush.h	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	Source/modules/push_messaging/ServiceWorkerGlobalScopePush.idl	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/ServiceWorkerGlobalScopeProxy.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/web/ServiceWorkerGlobalScopeProxy.cpp	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	public/web/WebServiceWorkerContextProxy.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download