Chromium Code Reviews
Help | Chromium Project | Sign in
(62)

Issue 3199019: Mac: Support compositor in fullscreen windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Nico
Modified:
4 years ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, stuartmorgan, pink
Visibility:
Public.

Description

Mac: Support compositor in fullscreen windows. It worked just fine, but since the window wasn't opaque, the underlayed surface didn't show through. BUG=53391 TEST=See bug

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/browser/cocoa/fullscreen_window.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/cocoa/fullscreen_window.mm View 1 chunk +18 lines, -0 lines 1 comment Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Nico
4 years, 9 months ago (2010-08-26 03:10:22 UTC) #1
viettrungluu
http://codereview.chromium.org/3199019/diff/1/3 File chrome/browser/cocoa/fullscreen_window.mm (right): http://codereview.chromium.org/3199019/diff/1/3#newcode106 chrome/browser/cocoa/fullscreen_window.mm:106: - (void)underlaySurfaceAdded { That's some pretty bad cutting-and-pasting going ...
4 years, 9 months ago (2010-08-26 03:12:53 UTC) #2
Nico
On Wed, Aug 25, 2010 at 8:12 PM, <viettrungluu@chromium.org> wrote: > > http://codereview.chromium.org/3199019/diff/1/3 > File ...
4 years, 9 months ago (2010-08-26 03:18:11 UTC) #3
Nico
4 years, 9 months ago (2010-08-26 03:20:42 UTC) #4
On Wed, Aug 25, 2010 at 8:18 PM, Nico Weber <thakis@chromium.org> wrote:
> On Wed, Aug 25, 2010 at 8:12 PM,  <viettrungluu@chromium.org> wrote:
>>
>> http://codereview.chromium.org/3199019/diff/1/3
>> File chrome/browser/cocoa/fullscreen_window.mm (right):
>>
>> http://codereview.chromium.org/3199019/diff/1/3#newcode106
>> chrome/browser/cocoa/fullscreen_window.mm:106: -
>> (void)underlaySurfaceAdded {
>> That's some pretty bad cutting-and-pasting going on there. Maybe we
>> should rename ChromeEventProcessingWindow,
>
> Can't do that, we don't want this for the extension bubbles.
>
>> or add something else into
>> (the middle of) the class hierarchy, where things like this can go?
>
> That seems like overkill to me.

Sounds like rohitrao wants to rehierarchize fullscreenwindow anyway,
he agreed to merge this CL in. Hooray!

>
>>
>> http://codereview.chromium.org/3199019/show
>>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be