Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319883002: Revert "[SVG2] Allow leading and trailing whitespace in svg attributes using" (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Visibility:
Public.

Description

Revert "[SVG2] Allow leading and trailing whitespace in svg attributes using" whitespace-length.html is timing out consistently on Webkit XP: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/svg/whitespace-length.html BUG=377503, 339899 TBR=ed@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -23611 lines) Patch
D LayoutTests/fast/svg/resources/whitespace-helper.js View 1 chunk +0 lines, -92 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-angle.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-angle-expected.txt View 1 chunk +0 lines, -5040 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-integer.html View 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-integer-expected.txt View 1 chunk +0 lines, -1539 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-length.html View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-length-expected.txt View 1 chunk +0 lines, -12228 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-number.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/svg/whitespace-number-expected.txt View 1 chunk +0 lines, -4410 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/svglength-animation-invalid-value-2.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/animations/script-tests/svglength-animation-invalid-value-3.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/invalid-length-units-expected.txt View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/svg/custom/script-tests/invalid-length-units.js View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/svg/hixie/error/015.xml View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAngle.cpp View 2 chunks +29 lines, -21 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGInteger.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 2 chunks +27 lines, -36 lines 0 comments Download
M Source/core/svg/SVGLengthList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumber.cpp View 2 chunks +14 lines, -5 lines 0 comments Download
M Source/core/svg/SVGParserUtilities.h View 4 chunks +12 lines, -13 lines 0 comments Download
M Source/core/svg/SVGParserUtilities.cpp View 9 chunks +10 lines, -51 lines 0 comments Download
M Source/core/svg/SVGPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPointList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStringList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransformList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
6 years, 6 months ago (2014-06-06 01:27:37 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r175616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698