Add a method to retrieve the top synchronous suggestion.

Add a method to retrieve the top synchronous suggestion.

Generally speaking top synchronous suggestion remains as a top
asynchronous suggestion as well. Get a quick preview of the top
suggestion by requesting just the synchronous one.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275399

[Yusuf, 2014-06-05 21:56:06]

https://codereview.chromium.org/319813002/diff/1/chrome/browser/android/omnib...
File chrome/browser/android/omnibox/autocomplete_controller_android.cc (right):

https://codereview.chromium.org/319813002/diff/1/chrome/browser/android/omnib...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:278:
AutocompleteControllerAndroid::GetTopSynchronousMatch(JNIEnv* env,
One question is the difference between this and classify. Can they share a bit
more code? It looks like there is one boolean flag that is different and one
just calls start with the initial input params and the other constructs the
input object and sends this to start.

Can we do most of this in a private shared method and pass one or two params to
control?

[Maria, 2014-06-05 23:16:57]

PTAL

[Yusuf, 2014-06-06 00:54:48]

On 2014/06/05 23:16:57, Maria wrote:
> PTAL

lgtm

Is ClassifyPage just moved around by mistake or did anything change in it?

[Maria, 2014-06-06 00:57:23]

On 2014/06/06 00:54:48, Yusuf wrote:
> On 2014/06/05 23:16:57, Maria wrote:
> > PTAL
> 
> lgtm
> 
> Is ClassifyPage just moved around by mistake or did anything change in it?

ClassifyPage moved to match .h ordering of methods -- there are no changes to
the code.

[Maria, 2014-06-06 00:58:00]

Dave, can you give me owners approval for this?

[David Trainor- moved to gerrit, 2014-06-06 01:20:39]

style nits but lgtm.

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java
(right):

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java:245:
* @param query User input text.
@return param

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
File chrome/browser/android/omnibox/autocomplete_controller_android.cc (right):

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:379: const
std::string& url = gurl.spec();
url(gurl.spec()) if it works w/ reference?

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:381: if
(gurl.SchemeIs(content::kChromeUIScheme) &&
new line after each if block or no new lines imo (seems to vary)

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:462:
Start(env, obj, j_text, NULL, NULL, prevent_inline_autocomplete, false, false,
each param on it's own line if they don't fit on a new line

[Maria, 2014-06-06 01:27:55]

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/android/ja...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java
(right):

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteController.java:245:
* @param query User input text.
On 2014/06/06 01:20:39, David Trainor wrote:
> @return param

Done.

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
File chrome/browser/android/omnibox/autocomplete_controller_android.cc (right):

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:379: const
std::string& url = gurl.spec();
On 2014/06/06 01:20:39, David Trainor wrote:
> url(gurl.spec()) if it works w/ reference?

That's not necessary with reference. Since there's no new object being
constructed in this call, there's no need to do that.

I believe that's only useful to avoid constructing and then immediately
overwriting an object.

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:381: if
(gurl.SchemeIs(content::kChromeUIScheme) &&
On 2014/06/06 01:20:39, David Trainor wrote:
> new line after each if block or no new lines imo (seems to vary)

Done.

https://chromiumcodereview.appspot.com/319813002/diff/40001/chrome/browser/an...
chrome/browser/android/omnibox/autocomplete_controller_android.cc:462:
Start(env, obj, j_text, NULL, NULL, prevent_inline_autocomplete, false, false,
On 2014/06/06 01:20:39, David Trainor wrote:
> each param on it's own line if they don't fit on a new line

Done.

GRRR. Have I mentioned to anyone lately how much I hate doing 1 param per line
style in calls with 10 parameters?

[Maria, 2014-06-06 01:35:40]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2014-06-06 01:37:08]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/319813002/6...

[commit-bot: I haz the power, 2014-06-06 11:14:30]

Change committed as 275399