Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3884)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 319783003: Sheriffing: Disable failing tests PrintCommands and TaskManagerNewPrintPreview on Linux LSAN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
index dfb6c4c84a753d93da7a9fafcccedf44e8ce37c6..81b33caba79cdf032dbf3907c70387b9700c6fc1 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc
@@ -48,6 +48,10 @@ class PrintPreviewTest : public InProcessBrowserTest {
}
};
+// The two tests below are failing on Linux LSAN
+// crbug.com/382523
+#if !defined(ADDRESS_SANITIZER)
+
IN_PROC_BROWSER_TEST_F(PrintPreviewTest, PrintCommands) {
// We start off at about:blank page.
// Make sure there is 1 tab and print is enabled.
@@ -100,6 +104,8 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, MAYBE_TaskManagerNewPrintPreview) {
ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchPrint("about:blank")));
}
+#endif
+
// Disable the test for mac as it started being flaky, see http://crbug/367665.
#if defined(OS_MACOSX) && !defined(OS_IOS)
#define MAYBE_TaskManagerExistingPrintPreview DISABLED_TaskManagerExistingPrintPreview
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698