Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 319783002: Fix crash from missing app.binding in extensions (Closed)

Created:
6 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix crash from missing app.binding in extensions. This fixes an issue where a lazy require of app bindings (when unavailable) will not yield a properly constructed bindings export. BUG=373179 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/resources/extensions/app_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Rockot(use gerrit already)
ptal - you were right.
6 years, 6 months ago (2014-06-05 19:36:27 UTC) #1
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-05 19:40:21 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-06-05 19:41:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/319783002/1
6 years, 6 months ago (2014-06-05 19:42:07 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:01:50 UTC) #5
Message was sent while issue was closed.
Change committed as 275329

Powered by Google App Engine
This is Rietveld 408576698