Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 319753004: Enqueue Blink microtasks using V8's C++ API (Closed)

Created:
6 years, 6 months ago by adamk
Modified:
6 years, 6 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rafaelw, rwlbuis, sof, dcarney
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Enqueue Blink microtasks using V8's C++ API This avoids allocating a v8::Function to wrap Blink microtask callbacks, which allows us to avoid entering a v8::Context to enqueue tasks. ScriptRegexp is now the only use of the v8::Context stored in V8PerIsolateData. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M Source/bindings/v8/ScriptRegexp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M Source/core/dom/Microtask.cpp View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
adamk
The android compile failure is just because it's a little too far behind. The V8 ...
6 years, 6 months ago (2014-06-05 18:52:52 UTC) #1
haraken
The ScriptRegexp part LGTM. jochen@ would want to look at the Microtask part.
6 years, 6 months ago (2014-06-06 00:46:59 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-06 06:54:36 UTC) #3
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 6 months ago (2014-06-06 15:45:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/319753004/1
6 years, 6 months ago (2014-06-06 15:46:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-06 16:52:43 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 16:55:00 UTC) #7
Message was sent while issue was closed.
Change committed as 175676

Powered by Google App Engine
This is Rietveld 408576698