Issue 319743002: Timeline: decouple TimelineFrameModel from TimelineModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319743002: Timeline: decouple TimelineFrameModel from TimelineModel (Closed)

Created:
6 years, 6 months ago by caseq

Modified:
6 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: decouple TimelineFrameModel from TimelineModel We'd like TimelineFrameModel to be independent from TimelineModel, since we may build the former based on row trace events. As a drive by, fix "no live updates" experiment which was broken in a couple of places, especially WRT displaying frames. BUG=361045 R=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175644

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -40 lines)			Patch
M	Source/devtools/front_end/timeline/TimelineFrameModel.js	View		8 chunks	+31 lines, -19 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineModel.js	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineModelImpl.js	View	1	4 chunks	+4 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/319743002/diff/1/Source/devtools/front_end/timeline/TimelineModel.js File Source/devtools/front_end/timeline/TimelineModel.js (left): https://codereview.chromium.org/319743002/diff/1/Source/devtools/front_end/timeline/TimelineModel.js#oldcode391 Source/devtools/front_end/timeline/TimelineModel.js:391: bufferEvents: function() You will need to rebase.

6 years, 6 months ago (2014-06-06 07:07:35 UTC) #2

caseq

6 years, 6 months ago (2014-06-06 07:40:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r175644 (presubmit successful).

Expand Messages | Collapse Messages