Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 319733003: [Mac] Don't show a title on app windows. (Closed)

Created:
6 years, 6 months ago by jackhou1
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Don't show a title on app windows. BUG=339558 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275449

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jackhou1
6 years, 6 months ago (2014-06-06 06:41:51 UTC) #1
tapted
lgtm with a nit https://codereview.chromium.org/319733003/diff/1/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right): https://codereview.chromium.org/319733003/diff/1/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm#newcode228 chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:228: - (BOOL)_isTitleHidden { nit: perhaps ...
6 years, 6 months ago (2014-06-06 06:57:51 UTC) #2
jackhou1
https://codereview.chromium.org/319733003/diff/1/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right): https://codereview.chromium.org/319733003/diff/1/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm#newcode228 chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:228: - (BOOL)_isTitleHidden { On 2014/06/06 06:57:51, tapted wrote: > ...
6 years, 6 months ago (2014-06-06 07:08:34 UTC) #3
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 6 months ago (2014-06-06 07:08:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/319733003/20001
6 years, 6 months ago (2014-06-06 07:10:38 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 13:13:54 UTC) #6
Robert Sesek
Please see https://code.google.com/p/chromium/issues/detail?id=380229
6 years, 6 months ago (2014-06-06 13:54:36 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 15:42:43 UTC) #8
Message was sent while issue was closed.
Change committed as 275449

Powered by Google App Engine
This is Rietveld 408576698