Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java - Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

Issue 319733002: DevTools: [JsDocValidator] Be smarter about function name and JSDoc detection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/sdk/InspectorBackend.js ('K') | « Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingChecker.java ('k') | Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/FunctionReceiverChecker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

diff --git a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

index 1a8d25de1e48382c1e1b20ba0135589cf41e3988..212ea1db64726adb04858a0797b8ed804447cece 100644

--- a/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

+++ b/Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/ContextTrackingValidationCheck.java

@@ -88,7 +88,7 @@ public class ContextTrackingValidationCheck extends ValidationCheck {

AstNode nameNode = AstUtil.getFunctionNameNode(node);

// It can be a type declaration: /** @constructor */ function MyType() {...}.

- String functionName = getNodeText(nameNode);

+ String functionName = nameNode == null ? null : getNodeText(nameNode);

boolean isConstructor =

functionName != null && rememberTypeRecordIfNeeded(functionName, jsDocNode);

TypeRecord parentType = state.getCurrentFunctionRecord() == null

@@ -96,6 +96,7 @@ public class ContextTrackingValidationCheck extends ValidationCheck {

: null;

state.pushFunctionRecord(new FunctionRecord(

node,

+ AstUtil.getJsDocNode(node),

functionName,

isConstructor,

getReturnType(jsDocNode),