Issue 319673003: Verify our assumptions about SCM commands deleting files from checkout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319673003: Verify our assumptions about SCM commands deleting files from checkout (Closed)

Created:
6 years, 6 months ago by Paweł Hajdan Jr.

Modified:
6 years, 6 months ago

Reviewers:
Sergey Berezin, jochen (gone - plz use gerrit)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Verify our assumptions about SCM commands deleting files from checkout BUG=131061 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=275235

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	checkout.py	View		3 chunks	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/319673003/diff/1/checkout.py File checkout.py (right): https://codereview.chromium.org/319673003/diff/1/checkout.py#newcode177 checkout.py:177: assert(not os.path.exists(filepath)) this won't work if filepath is ...

6 years, 6 months ago (2014-06-05 13:33:26 UTC) #2

Sergey Berezin

The CQ bit was checked by sergeyberezin@chromium.org

6 years, 6 months ago (2014-06-05 20:31:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/319673003/1

6 years, 6 months ago (2014-06-05 20:32:02 UTC) #4

Message was sent while issue was closed.

Change committed as 275235

Expand Messages | Collapse Messages