Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319653002: Cleanup v8 usage in modules (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken, eseidel
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, alecflett, ericu+idb_chromium.org, falken, dgrogan, nhiroki, cmumford, horo+watch_chromium.org, kinuko+serviceworker, jsbell+idb_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Cleanup v8 usage in modules Followup to: Cleanup v8 usage in core https://codereview.chromium.org/318843003/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175549

Patch Set 1 #

Patch Set 2 : Revised #

Patch Set 3 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/WebSocketTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Nils Barth (inactive)
6 years, 6 months ago (2014-06-05 05:52:43 UTC) #1
haraken
Unfortunately not LGTM for the same reason as https://codereview.chromium.org/318843003/ ...:(
6 years, 6 months ago (2014-06-05 05:58:10 UTC) #2
Nils Barth (inactive)
Revised as core one (just adds previously transitive includes).
6 years, 6 months ago (2014-06-05 06:12:07 UTC) #3
haraken
LGTM
6 years, 6 months ago (2014-06-05 06:27:36 UTC) #4
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-05 06:34:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/319653002/20001
6 years, 6 months ago (2014-06-05 06:35:00 UTC) #6
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 6 months ago (2014-06-05 06:44:48 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-05 06:45:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/319653002/40001
6 years, 6 months ago (2014-06-05 06:47:16 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 07:52:25 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 08:22:57 UTC) #11
Message was sent while issue was closed. 
Change committed as 175549

Powered by Google App Engine
This is Rietveld 408576698