Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 319643002: Fixed touch selection handle manipulation when pinched in. (Closed)

Created:
6 years, 6 months ago by bokan
Modified:
6 years, 6 months ago
CC:
blink-reviews, jdduke (slow)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fixed touch selection handle manipulation when pinched in. This patch applies the pinch viewport offset to selection handle coordinates when passing the coordinates into Blink. This fixes the case where selection handles would appear in the wrong place while being manipulated while pinched in or when the ChromeOS on-screen keyboard is showing. BUG=376332

Patch Set 1 #

Patch Set 2 : Small nit in test data #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A + Source/web/tests/data/move_range.html View 1 2 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bokan
PTAL, thanks.
6 years, 6 months ago (2014-06-04 22:37:12 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 6 months ago (2014-06-05 20:46:17 UTC) #2
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 6 months ago (2014-06-05 20:49:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/319643002/20001
6 years, 6 months ago (2014-06-05 20:50:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-05 22:08:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 22:08:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14492)
6 years, 6 months ago (2014-06-05 22:08:21 UTC) #7
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 6 months ago (2014-06-06 16:43:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/319643002/40001
6 years, 6 months ago (2014-06-06 16:44:18 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 17:50:37 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 17:50:37 UTC) #11
Could not make sense out of svn commit message.

Powered by Google App Engine
This is Rietveld 408576698