LayoutTests/screen_orientation/page-visibility.html - Issue 319633007: Move WebScreenOrientationClient to WebFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/page-visibility.html

Issue 319633007: Move WebScreenOrientationClient to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: don't send the events multiple times Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Source/modules/screen_orientation/ScreenOrientation.h » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/page-visibility.html

diff --git a/LayoutTests/screen_orientation/page-visibility.html b/LayoutTests/screen_orientation/page-visibility.html

index 874988d69d766da069d8168dfaf7a694998f35d6..8a1517d6ba6be0f22291009cc1a90b9c91eae176 100644

--- a/LayoutTests/screen_orientation/page-visibility.html

+++ b/LayoutTests/screen_orientation/page-visibility.html

@@ -3,13 +3,19 @@

<body>

+<iframe src='about:blank'></iframe>

var orientationChangeEventListenerCalls = 0;

+var orientationChangeEventListenerCallsForFrame = 0;

window.addEventListener('orientationchange', function() {

orientationChangeEventListenerCalls++;

});

+window.frames[0].addEventListener('orientationchange', function() {

+ orientationChangeEventListenerCallsForFrame++;

+});

test(function() {

assert_false(document.hidden);

if (window.testRunner)

@@ -42,6 +48,11 @@ test(function() {

// Should keep returning the start returning the orientation value.

assert_equals(screen.orientation, "portrait-primary");

}, "Test that screen.orientation is updated once the page is visible again");

+test(function() {

+ assert_equals(orientationChangeEventListenerCallsForFrame, orientationChangeEventListenerCalls);

+}, "Test that the iframe got as many events as the main frame.")

</script>

</body>

</html>

« no previous file with comments | « no previous file | Source/modules/screen_orientation/ScreenOrientation.h » ('j') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('J')