Issue 319633005: Revert 275492 "ChromeOS login webui refactoring : Simplify login..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319633005: Revert 275492 "ChromeOS login webui refactoring : Simplify login..." (Closed)

Created:
6 years, 6 months ago by pavely

Modified:
6 years, 6 months ago

Reviewers:
Denis Kuznetsov (DE-MUC)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 275492 "ChromeOS login webui refactoring : Simplify login..." This change preventing me from reverting r275046 which seems to be causing failures in KioskTest http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/35748 > ChromeOS login webui refactoring : Simplify login methods. > > > BUG=373314 > R=nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/324463003 TBR=antrim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275548

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+202 lines, -210 lines)			Patch
M	trunk/src/chrome/browser/chromeos/login/app_launch_signin_screen.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/app_launch_signin_screen.cc	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/auth/user_context.h	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/auth/user_context.cc	View	4 chunks	+7 lines, -18 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/existing_user_controller.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc	View	2 chunks	+6 lines, -21 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/lock/webui_screen_locker.h	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/lock/webui_screen_locker.cc	View	2 chunks	+21 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/login_manager_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/signin/oauth2_browsertest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/login/signin_specifics.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/login/signin_specifics.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/ui/login_display.h	View	3 chunks	+38 lines, -24 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/ui/webui_login_display.h	View	3 chunks	+12 lines, -11 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/ui/webui_login_display.cc	View	2 chunks	+25 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View	4 chunks	+45 lines, -39 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	5 chunks	+5 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_chromeos.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pavely

6 years, 6 months ago (2014-06-06 23:22:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275548 (tree was closed).

Expand Messages | Collapse Messages