Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 319633004: Fix scrollWidth/Height to not truncate scroll offset (Closed)

Created:
6 years, 6 months ago by eae
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Fix scrollWidth/Height to not truncate scroll offset Fix bug in Element::scrollWidth/scrollHeight where the scroll offset was truncated to an integer value before being adjusted for zoom. TEST=fast/sub-pixel/clientwidth-matches-scrollwidth-for-float.html BUG=381039 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eae
6 years, 6 months ago (2014-06-06 18:17:49 UTC) #1
eae
6 years, 6 months ago (2014-06-06 19:43:15 UTC) #2
dglazkov
lgtm
6 years, 6 months ago (2014-06-06 19:44:03 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-06 19:48:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/319633004/1
6 years, 6 months ago (2014-06-06 19:49:30 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:05:50 UTC) #6
Message was sent while issue was closed.
Change committed as 175698

Powered by Google App Engine
This is Rietveld 408576698