Source/core/inspector/InspectorLayerTreeAgent.cpp - Issue 319603007: DevTools: Add snapshot command log on the frontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorLayerTreeAgent.cpp

Issue 319603007: DevTools: Add snapshot command log on the frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorLayerTreeAgent.h ('K') | « Source/core/inspector/InspectorLayerTreeAgent.h ('k') | Source/devtools/front_end/layers/PaintProfilerView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorLayerTreeAgent.cpp

diff --git a/Source/core/inspector/InspectorLayerTreeAgent.cpp b/Source/core/inspector/InspectorLayerTreeAgent.cpp

index 40d0d35c7184d2a528326bbbfc78d5d81a34d7d1..d4f502156d4f33a9f8170efc3306598e050d86b1 100644

--- a/Source/core/inspector/InspectorLayerTreeAgent.cpp

+++ b/Source/core/inspector/InspectorLayerTreeAgent.cpp

@@ -382,12 +382,12 @@ void InspectorLayerTreeAgent::profileSnapshot(ErrorString* errorString, const St

}

-void InspectorLayerTreeAgent::snapshotCommandLog(ErrorString* errorString, const String& snapshotId, RefPtr<TypeBuilder::Array<JSONObject> >& commandLog)

+void InspectorLayerTreeAgent::snapshotCommandLog(ErrorString* errorString, const String& snapshotId, const int* fromStep, const int* toStep, RefPtr<TypeBuilder::Array<JSONObject> >& commandLog)

{

const GraphicsContextSnapshot* snapshot = snapshotById(errorString, snapshotId);

if (!snapshot)

return;

- commandLog = TypeBuilder::Array<JSONObject>::runtimeCast(snapshot->snapshotCommandLog());

+ commandLog = TypeBuilder::Array<JSONObject>::runtimeCast(snapshot->snapshotCommandLog(fromStep ? *fromStep : 0, toStep ? *toStep : 0));

}

void InspectorLayerTreeAgent::willAddPageOverlay(const GraphicsLayer* layer)