Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 319603004: Revert of Replace the HomeCard by the AppList in Athena. (Closed)

Created:
6 years, 6 months ago by Marijn Kruisselbrink
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Replace the HomeCard by the AppList in Athena. (https://codereview.chromium.org/306083005/) Reason for revert: Seems to break compilation on Linux Chromium OS ASan LSan Builder: FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -pthread -Wl,-z,noexecstack -fPIC -B/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wl,--disable-new-dtags -L. -Wl,-u_sanitizer_options_link_helper -m64 -fsanitize=address -fsanitize=leak -Wl,--icf=none -Wl,-O1 -Wl,--gc-sections -o athena_shell -Wl,--start-group [..] ../../content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:61:error: undefined reference to 'ppapi::host::PpapiHost::PpapiHost(IPC::Sender*, ppapi::PpapiPermissions const&)' ../../content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc:63:error: undefined reference to 'ppapi::host::PpapiHost::AddHostFactoryFilter(scoped_ptr<ppapi::host::HostFactory, base::DefaultDeleter<ppapi::host::HostFactory> >)' ../../content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc:123:error: undefined reference to 'ppapi::host::MessageFilterHost::MessageFilterHost(ppapi::host::PpapiHost*, int, int, scoped_refptr<ppapi::host::ResourceMessageFilter> const&)' ../../content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc:93:error: undefined reference to 'ppapi::host::MessageFilterHost::MessageFilterHost(ppapi::host::PpapiHost*, int, int, scoped_refptr<ppapi::host::ResourceMessageFilter> const&)' [etc...] Original issue's description: > Replace the HomeCard by the AppList in Athena. > > BUG=370204 > R=oshima@chromium.org, benwells@chromium.org > TBR=reed@google.com > TEST=manually > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274942 TBR=oshima@chromium.org,benwells@chromium.org,xiyuan@chromium.org,reed@google.com,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=370204 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -325 lines) Patch
M athena/athena.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M athena/home/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D athena/home/app_list_view_delegate.h View 1 chunk +0 lines, -64 lines 0 comments Download
D athena/home/app_list_view_delegate.cc View 1 chunk +0 lines, -234 lines 0 comments Download
A athena/home/home_card_delegate_view.h View 1 chunk +33 lines, -0 lines 0 comments Download
A athena/home/home_card_delegate_view.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M athena/home/home_card_impl.cc View 5 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Marijn Kruisselbrink
Created Revert of Replace the HomeCard by the AppList in Athena.
6 years, 6 months ago (2014-06-04 23:36:55 UTC) #1
Marijn Kruisselbrink
The CQ bit was unchecked by mek@chromium.org
6 years, 6 months ago (2014-06-04 23:38:07 UTC) #2
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org
6 years, 6 months ago (2014-06-04 23:38:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/319603004/1
6 years, 6 months ago (2014-06-04 23:40:57 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 23:43:07 UTC) #5
Message was sent while issue was closed.
Change committed as 274953

Powered by Google App Engine
This is Rietveld 408576698