Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 319603003: [Downloads] Retry renames after transient failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Prepare to reland after XP test fix. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/public/browser/download_interrupt_reason_values.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 0c722c234469ee92bdb5811c4b71cf15d8b84949..3136505c849711405f0cb401341befec1521a11e 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -5546,6 +5546,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="Download.MapWinShErrorTransientError"
+ enum="SpecialShFileOperationCodes">
+ <owner>asanka@chromium.org</owner>
+ <summary>
+ Windows error that produced a DOWNLOAD_INTERRUPT_REASON_FILE_TRANSIENT_ERROR
+ result in MapShFileOperationCodes().
+ </summary>
+</histogram>
+
<histogram name="Download.OnChanged">
<owner>asanka@chromium.org</owner>
<summary>
@@ -5679,6 +5688,24 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>Time between the start of a download and its completion.</summary>
</histogram>
+<histogram name="Download.TimeToRenameFailureAfterInitialFailure"
+ units="milliseconds">
+ <owner>asanka@chromium.org</owner>
+ <summary>
+ Time elapsed until a retried download file rename operation failed for the
+ last time after the initial rename failed.
+ </summary>
+</histogram>
+
+<histogram name="Download.TimeToRenameSuccessAfterInitialFailure"
+ units="milliseconds">
+ <owner>asanka@chromium.org</owner>
+ <summary>
+ Time elapsed until a retried download file rename operation succeeded after
+ the initial rename failed.
+ </summary>
+</histogram>
+
<histogram name="Download.UserDiscard" enum="DownloadItem.DangerType">
<owner>asanka@chromium.org</owner>
<owner>felt@chromium.org</owner>
@@ -50790,7 +50817,9 @@ To add a new entry, add it with any value and run test to compute valid value.
<enum name="SpecialShFileOperationCodes" type="int">
<summary>Legacy error codes still returned by |ShFileOperation()|</summary>
- <int value="5" label="Access denied"/>
+ <int value="5" label="Access denied (Win32)"/>
+ <int value="32" label="Sharing violation (Win32)"/>
+ <int value="87" label="Invalid parameter (Win32)"/>
<int value="113" label="Source and Destination are same file"/>
<int value="114" label="Multiple source mapped to single destination"/>
<int value="115" label="Rename to different directory"/>
« no previous file with comments | « content/public/browser/download_interrupt_reason_values.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698