content/browser/download/base_file_posix.cc - Issue 319603003: [Downloads] Retry renames after transient failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/base_file_posix.cc

Issue 319603003: [Downloads] Retry renames after transient failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Prepare to reland after XP test fix. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/base_file_posix.cc

diff --git a/content/browser/download/base_file_posix.cc b/content/browser/download/base_file_posix.cc

index 27940be38ada7e5e5d04f220b04fdc1ef2fcab56..b5d8e01442244b0f0a4fb45b60d3060618bb4786 100644

--- a/content/browser/download/base_file_posix.cc

+++ b/content/browser/download/base_file_posix.cc

@@ -27,8 +27,6 @@ DownloadInterruptReason BaseFile::MoveFileAndAdjustPermissions(

if (!stat_succeeded)

LogSystemError("stat", errno);

- // TODO(estade): Move() falls back to copying and deleting when a simple

- // rename fails. Copying sucks for large downloads. crbug.com/8737

if (!base::Move(full_path_, new_path))

return LogSystemError("Move", errno);