[Downloads] Retry renames after transient failures.

content/browser/download/download_stats.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Holds helpers for gathering UMA stats about downloads.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_STATS_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_STATS_H_
 
 #include <string>
@@ skipping 182 matching lines @@
 // how often, for each download, something other than the network
 // was the bottleneck).
 void RecordNetworkBlockage(base::TimeDelta resource_handler_lifetime,
                            base::TimeDelta resource_handler_blocked_time);
 
 // Record overall bandwidth stats at the file end.
 void RecordFileBandwidth(size_t length,
                          base::TimeDelta disk_write_time,
                          base::TimeDelta elapsed_time);
 
+// Record the result of a download file rename.

[Randy Smith (Not in Mondays), 2014/06/10 19:22:02]

I think there should probably be some doc in this comment about the
conditionalization on time_of_first_failure null values and why.  (Or maybe
rethinking calling structure; it's a little funny to have a bail this low in the
callstack dependent on a null value in a time argument).

[asanka, 2014/06/10 22:36:21]

Yeah. I changed the call stack and the arguments.

+void RecordDownloadFileRenameResult(
+    base::TimeTicks time_of_first_failure,
+    DownloadInterruptReason interrupt_reason);
+
 enum SavePackageEvent {
   // The user has started to save a page as a package.
   SAVE_PACKAGE_STARTED,
 
   // The save package operation was cancelled.
   SAVE_PACKAGE_CANCELLED,
 
   // The save package operation finished without being cancelled.
   SAVE_PACKAGE_FINISHED,
 
@@ skipping 17 matching lines @@
 
 // Record the state of the origin information across a download resumption
 // request. |state| is a combination of values from OriginStateOnResumption
 // enum.
 void RecordOriginStateOnResumption(bool is_partial,
                                    int state);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_STATS_H_