Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: net/socket/stream_listen_socket.h

Issue 319593013: Added unit test for DevTools' ephemeral port support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review feedback from wtc. Made Get{Local,Peer}Address virtual. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/stream_listen_socket.h
diff --git a/net/socket/stream_listen_socket.h b/net/socket/stream_listen_socket.h
index 90b54500ace17f2f28631f3fa8449e644564f298..813d96a22be8f19dfb3cddb90c8d1f90707e8c6e 100644
--- a/net/socket/stream_listen_socket.h
+++ b/net/socket/stream_listen_socket.h
@@ -72,9 +72,11 @@ class NET_EXPORT StreamListenSocket
void Send(const std::string& str, bool append_linefeed = false);
// Copies the local address to |address|. Returns a network error code.
- int GetLocalAddress(IPEndPoint* address);
+ // This method is virtual to support unit testing.
+ virtual int GetLocalAddress(IPEndPoint* address);
// Copies the peer address to |address|. Returns a network error code.
- int GetPeerAddress(IPEndPoint* address);
+ // This method is virtual to support unit testing.
+ virtual int GetPeerAddress(IPEndPoint* address);
static const int kSocketError;
« no previous file with comments | « content/browser/devtools/devtools_http_handler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698