Added unit test for DevTools' ephemeral port support.

content/browser/devtools/devtools_http_handler_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_http_handler_impl.h"
 
 #include <algorithm>
-#include <sstream>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/stl_util.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/threading/thread.h"
 #include "base/values.h"
 #include "content/browser/devtools/devtools_browser_target.h"
 #include "content/browser/devtools/devtools_protocol.h"
 #include "content/browser/devtools/devtools_protocol_constants.h"
 #include "content/browser/devtools/devtools_system_info_handler.h"
 #include "content/browser/devtools/devtools_tracing_handler.h"
 #include "content/browser/devtools/tethering_handler.h"
 #include "content/common/devtools_messages.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 664 matching lines @@
   int err;
   if ((err = server_->GetLocalAddress(&endpoint)) != net::OK) {
     LOG(ERROR) << "Error " << err << " getting local address";
     return;
   }
 
   // Write this port to a well-known file in the profile directory
   // so Telemetry can pick it up.
   base::FilePath path = active_port_output_directory_.Append(
       kDevToolsActivePortFileName);
-  std::stringstream port_stream;
-  port_stream << endpoint.port();
-  std::string s = port_stream.str();
-  if (base::WriteFile(path, s.c_str(), s.length()) < 0) {
+  std::string port_string = base::IntToString(endpoint.port());
+  if (base::WriteFile(path, port_string.c_str(), port_string.length()) < 0) {

[wtc, 2014/06/10 17:46:44]

Nit: we can use data() instead of c_str(), which in theory does not require the
conversion to a C string.

     LOG(ERROR) << "Error writing DevTools active port to file";
   }
 }
 
 void DevToolsHttpHandlerImpl::SendJson(int connection_id,
                                        net::HttpStatusCode status_code,
                                        base::Value* value,
                                        const std::string& message) {
   if (!thread_)
     return;
@@ skipping 100 matching lines @@
         id.c_str(),
         host);
     dictionary->SetString(
         kTargetDevtoolsFrontendUrlField, devtools_frontend_url);
   }
 
   return dictionary;
 }
 
 }  // namespace content