Issue 319593006: IDL build: remove dependency core global constructors → modules global objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319593006: IDL build: remove dependency core global constructors → modules global objects (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)

Modified:
6 years, 6 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL build: remove dependency core global constructors → modules global objects Moves "constructors on modules global objects from core interfaces" to modules. I.e., moves ServiceWorkerGlobalScopeCore.idl from gen/blink/core to gen/blink/modules bindings/core/generated.gyp no longer references modules! R=haraken BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175631

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -51 lines)			Patch
M	Source/bindings/core/generated.gyp	View	1	6 chunks	+4 lines, -46 lines	0 comments	Download
M	Source/bindings/core/generated.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/modules/generated.gyp	View	1	4 chunks	+78 lines, -2 lines	0 comments	Download
M	Source/bindings/modules/generated.gypi	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	Source/bindings/modules/idl.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 6 months ago (2014-06-06 01:13:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/319593006/20001

6 years, 6 months ago (2014-06-06 01:13:56 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-06 02:18:57 UTC) #5

Message was sent while issue was closed.

Change committed as 175631

Expand Messages | Collapse Messages