Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319593003: Update to NSS 3.16.2 Beta 3. (Closed)

Created:
6 years, 6 months ago by wtc
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Update to NSS 3.16.2 Beta 3. R=rsleevi@chromium.org BUG=380925

Patch Set 1 #

Patch Set 2 : Remove unused function SEC_NumberOrNameStringToOIDTag #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+921 lines, -2362 lines) Patch
M README.chromium View 3 chunks +3 lines, -16 lines 0 comments Download
M nss.gyp View 3 chunks +2 lines, -1 line 0 comments Download
M nss/lib/certdb/alg1485.c View 3 chunks +5 lines, -5 lines 0 comments Download
M nss/lib/certdb/cert.h View 1 chunk +0 lines, -7 lines 0 comments Download
M nss/lib/certdb/certdb.h View 1 chunk +10 lines, -10 lines 0 comments Download
M nss/lib/certdb/genname.h View 1 chunk +3 lines, -0 lines 0 comments Download
M nss/lib/certdb/genname.c View 3 chunks +111 lines, -3 lines 2 comments Download
M nss/lib/certhigh/ocsp.c View 1 chunk +1 line, -2 lines 0 comments Download
M nss/lib/ckfw/builtins/certdata.c View 104 chunks +111 lines, -277 lines 0 comments Download
M nss/lib/ckfw/builtins/nssckbi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/cryptohi/cryptohi.h View 2 chunks +2 lines, -2 lines 0 comments Download
M nss/lib/cryptohi/keyhi.h View 3 chunks +3 lines, -13 lines 0 comments Download
M nss/lib/cryptohi/seckey.c View 3 chunks +22 lines, -69 lines 0 comments Download
M nss/lib/cryptohi/secsign.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/freebl/blapi.h View 2 chunks +13 lines, -1 line 0 comments Download
M nss/lib/freebl/blapii.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/freebl/blapit.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/freebl/ctr.c View 6 chunks +8 lines, -8 lines 0 comments Download
A + nss/lib/freebl/ecdecode.c View 1 chunk +4 lines, -0 lines 0 comments Download
M nss/lib/freebl/rijndael.c View 9 chunks +28 lines, -9 lines 0 comments Download
M nss/lib/freebl/rsa.c View 2 chunks +17 lines, -14 lines 0 comments Download
M nss/lib/nss/nss.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/nss/nssinit.c View 2 chunks +10 lines, -8 lines 0 comments Download
M nss/lib/pk11wrap/pk11akey.c View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/pk11wrap/pk11cert.c View 1 chunk +7 lines, -0 lines 2 comments Download
M nss/lib/pk11wrap/pk11cxt.c View 1 chunk +3 lines, -0 lines 0 comments Download
M nss/lib/pk11wrap/pk11load.c View 3 chunks +30 lines, -7 lines 0 comments Download
M nss/lib/pk11wrap/pk11pub.h View 2 chunks +2 lines, -2 lines 0 comments Download
M nss/lib/pk11wrap/pk11skey.c View 1 chunk +3 lines, -1 line 0 comments Download
M nss/lib/pk11wrap/pk11slot.c View 3 chunks +9 lines, -2 lines 0 comments Download
M nss/lib/pk11wrap/pk11util.c View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/pk11wrap/secmod.h View 2 chunks +2 lines, -0 lines 0 comments Download
M nss/lib/pk11wrap/secmodi.h View 1 chunk +0 lines, -1 line 0 comments Download
M nss/lib/pk11wrap/secmodt.h View 1 chunk +4 lines, -4 lines 0 comments Download
D nss/lib/softoken/ecdecode.c View 1 chunk +0 lines, -606 lines 0 comments Download
M nss/lib/softoken/pkcs11.c View 10 chunks +88 lines, -52 lines 3 comments Download
M nss/lib/softoken/softkver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/softoken/softoken.h View 1 chunk +0 lines, -13 lines 0 comments Download
M nss/lib/ssl/sslerr.h View 2 chunks +136 lines, -133 lines 0 comments Download
M nss/lib/util/nssutil.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/util/secdig.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/util/secdigt.h View 2 chunks +1 line, -3 lines 0 comments Download
M nss/lib/util/secerr.h View 1 chunk +178 lines, -178 lines 0 comments Download
M nss/lib/util/utilmod.c View 8 chunks +79 lines, -28 lines 0 comments Download
M nss/lib/util/utilmodt.h View 1 chunk +2 lines, -1 line 0 comments Download
D patches/nss-export-private-key-info.patch View 1 chunk +0 lines, -213 lines 0 comments Download
D patches/nss-intel-aes-windows.patch View 1 chunk +0 lines, -272 lines 0 comments Download
D patches/nss-rsa-oaep.patch View 1 chunk +0 lines, -377 lines 0 comments Download
M scripts/nss-checkout.sh View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wtc
https://codereview.chromium.org/319593003/diff/20001/nss/lib/softoken/pkcs11.c File nss/lib/softoken/pkcs11.c (right): https://codereview.chromium.org/319593003/diff/20001/nss/lib/softoken/pkcs11.c#newcode3200 nss/lib/softoken/pkcs11.c:3200: pInfo->firmwareVersion.minor = SOFTOKEN_VBUILD; Are you sure we want to ...
6 years, 6 months ago (2014-06-04 23:58:11 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/319593003/diff/20001/nss/lib/softoken/pkcs11.c File nss/lib/softoken/pkcs11.c (right): https://codereview.chromium.org/319593003/diff/20001/nss/lib/softoken/pkcs11.c#newcode3200 nss/lib/softoken/pkcs11.c:3200: pInfo->firmwareVersion.minor = SOFTOKEN_VBUILD; On 2014/06/04 23:58:11, wtc wrote: > ...
6 years, 6 months ago (2014-06-05 00:13:45 UTC) #2
Ryan Sleevi
lgtm https://codereview.chromium.org/319593003/diff/20001/nss/lib/certdb/genname.c File nss/lib/certdb/genname.c (right): https://codereview.chromium.org/319593003/diff/20001/nss/lib/certdb/genname.c#newcode1595 nss/lib/certdb/genname.c:1595: ".tf"; We should compare this with our constraints, ...
6 years, 6 months ago (2014-06-05 00:22:30 UTC) #3
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-05 00:47:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/319593003/20001
6 years, 6 months ago (2014-06-05 00:48:07 UTC) #5
commit-bot: I haz the power
Change committed as 274968
6 years, 6 months ago (2014-06-05 00:49:11 UTC) #6
wtc
6 years, 6 months ago (2014-06-05 03:00:10 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/319593003/diff/20001/nss/lib/certdb/genname.c
File nss/lib/certdb/genname.c (right):

https://codereview.chromium.org/319593003/diff/20001/nss/lib/certdb/genname.c...
nss/lib/certdb/genname.c:1595: ".tf";

This is the same as our list in net/cert/cert_verify_proc.cc
505 	"fr", // France
506 	"gp", // Guadeloupe
507 	"gf", // Guyane
508 	"mq", // Martinique
509 	"re", // Réunion
510 	"yt", // Mayotte
511 	"pm", // Saint-Pierre et Miquelon
512 	"bl", // Saint Barthélemy
513 	"mf", // Saint Martin
514 	"wf", // Wallis et Futuna
515 	"pf", // Polynésie française
516 	"nc", // Nouvelle Calédonie
517 	"tf", // Terres australes et antarctiques françaises

https://codereview.chromium.org/319593003/diff/20001/nss/lib/pk11wrap/pk11cert.c
File nss/lib/pk11wrap/pk11cert.c (right):

https://codereview.chromium.org/319593003/diff/20001/nss/lib/pk11wrap/pk11cer...
nss/lib/pk11wrap/pk11cert.c:987: nssCertificate_AddRef(c);

On 2014/06/05 00:22:30, Ryan Sleevi wrote:
> I wonder if this is responsible for the crashes we've been seeing

Yes, this is the best lead I have. I found PK11_ImportCert calls
in the Chromium source tree, e.g., in net/cert/cert_database_nss.cc.

https://codereview.chromium.org/319593003/diff/20001/nss/lib/softoken/pkcs11.c
File nss/lib/softoken/pkcs11.c (right):

https://codereview.chromium.org/319593003/diff/20001/nss/lib/softoken/pkcs11....
nss/lib/softoken/pkcs11.c:3200: pInfo->firmwareVersion.minor = SOFTOKEN_VBUILD;

On 2014/06/05 00:13:45, Ryan Sleevi wrote:
> The firmware version is tied to the hardware version, so it still keeps the
> precedence of implementation.

A firmware version may support multiple hardware versions, so their relation is
not quite the same as what patch.build is to major.minor. But this analogy is a
good way to motivate why we interpret firmware version this way.

Powered by Google App Engine
This is Rietveld 408576698