Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 319593002: [CSS Grid Layout] RenderGrid::growGrid refactoring (Closed)

Created:
6 years, 6 months ago by Manuel Rego
Modified:
6 years, 6 months ago
CC:
blink-reviews, jfernandez, blink-reviews-rendering, zoltan1, svillar, Manuel Rego, leviw+renderwatch, eae+blinkwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] RenderGrid::growGrid refactoring Now it's called RenderGrid::ensureGridSize and it allows to grow both directions at once. Remove checkings before calling it as they are not needed anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175885

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M Source/core/rendering/RenderGrid.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 1 chunk +10 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Manuel Rego
Small refactoring in growGrid as suggested by @jchaffraix at https://codereview.chromium.org/196943026/#msg14
6 years, 6 months ago (2014-06-04 20:14:12 UTC) #1
Julien - ping for review
lgtm https://codereview.chromium.org/319593002/diff/1/Source/core/rendering/RenderGrid.cpp File Source/core/rendering/RenderGrid.cpp (right): https://codereview.chromium.org/319593002/diff/1/Source/core/rendering/RenderGrid.cpp#newcode731 Source/core/rendering/RenderGrid.cpp:731: void RenderGrid::growGrid(size_t maximumRowIndex, size_t maximumColumnIndex) I think the ...
6 years, 6 months ago (2014-06-10 00:13:00 UTC) #2
Manuel Rego
Thanks for the review. https://codereview.chromium.org/319593002/diff/1/Source/core/rendering/RenderGrid.cpp File Source/core/rendering/RenderGrid.cpp (right): https://codereview.chromium.org/319593002/diff/1/Source/core/rendering/RenderGrid.cpp#newcode731 Source/core/rendering/RenderGrid.cpp:731: void RenderGrid::growGrid(size_t maximumRowIndex, size_t maximumColumnIndex) ...
6 years, 6 months ago (2014-06-10 10:25:55 UTC) #3
Manuel Rego
The CQ bit was checked by rego@igalia.com
6 years, 6 months ago (2014-06-10 10:26:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/319593002/10001
6 years, 6 months ago (2014-06-10 10:27:16 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 11:30:04 UTC) #6
Message was sent while issue was closed.
Change committed as 175885

Powered by Google App Engine
This is Rietveld 408576698