tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1b11267a54572745b7af47f1d68c8f8d49ceecd0..e23c149a96df6b010e0f6671a820824a85ed1ade 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -24240,6 +24240,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Signin" enum="SigninHelperFlow">

[Alexei Svitkine (slow), 2014/06/16 17:35:24]

I think this should be Signin.Actions.

[Mike Lerman, 2014/06/16 17:41:59]

I would think so too, but there are existing over a dozen histograms that all
have names like Signin.SettingsActions or Signin.StartPageActions. I don't want
to lose the history we already have.

+  <owner>mlerman@chromium.org</owner>
+  <summary>Tracks user interactions as they sign in through a flow.</summary>
+</histogram>
+
 <histogram name="Signin.OneClickConfirmation" enum="SigninFlowConfirmations">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <summary>
@@ -42116,6 +42121,39 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="13" label="Learn more undo"/>
 </enum>
 
+<enum name="SigninHelperFlow" type="int">
+  <int value="0" label="Shown">The infobar was shown to the user.</int>
+  <int value="1" label="Accepted">
+    The user pressed the accept button to perform the suggested action.
+  </int>
+  <int value="2" label="Rejected">
+    The user pressed the reject to turn off the feature.
+  </int>
+  <int value="3" label="Dismissed">
+    The user pressed the X button to dismiss the infobar this time.
+  </int>
+  <int value="4" label="Ignored">
+    The user completely ignored the infoar.  Either they navigated away, or they
+    used the page as is.
+  </int>
+  <int value="5" label="Learn More">
+    The user clicked on the learn more link in the infobar.
+  </int>
+  <int value="6" label="Accept with Defaults">
+    The sync was started with default settings.
+  </int>
+  <int value="7" label="Accept with Advanced">
+    The sync was started with advanced settings.
+  </int>
+  <int value="8" label="Auto-Accept with Defaults">
+    The sync was started through auto-accept with default settings.
+  </int>
+  <int value="9" label="Auto-Accept with Advanced">
+    The sync was started through auto-accept with advanced settings.
+  </int>
+  <int value="10" label="Undo">The sync was aborted with an undo button.</int>
+</enum>
+
 <enum name="SimpleCache.EntryCreatedAndStream2Omitted" type="int">
   <int value="0" label="Stream 2 file was present"/>
   <int value="1" label="Empty stream 2 file was omitted"/>
@@ -46927,6 +46965,22 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <affected-histogram name="Extensions.UpdateSource"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="Signin.Actions" separator=".">
+  <suffix name="AllAccessPointActions"/>
+  <suffix name="AndroidAccountConsistencyFirstRunActions"
+      label="Signin Flow shown on android after Account Consistency flag was
+             enabled."/>
+  <suffix name="AppLauncherActions"/>
+  <suffix name="ExtensionInstallBubbleActions"/>

[Alexei Svitkine (slow), 2014/06/16 17:35:24]

I'm not sure I understand these.

What does it mean for Signin.Actions.ExtensionInstallBubbleActions.Shown? What
infobar was shown to the user and how does that relate to the install bubble?

[Mike Lerman, 2014/06/16 17:41:59]

This would mean that the user was directed to the common Signin-and-Sync flow,
originating from the Extension Installer Bubble. Once in this flow, the user was
Shown the infobar (e.g. the bubble).

[Alexei Svitkine (slow), 2014/06/16 17:52:44]

Wait. An infobar is not a bubble, so "Shown the infobar (e.g. the bubble)"
doesn't make sense to me. Perhaps the description for the "Shown" entry needs to
change?

Also, the above information (i.e. what this means) needs to be captured
somewhere - maybe in the description for the "Signin" top-level histogram -
perhaps by explaining an example like you did in this reply to me.

[Mike Lerman, 2014/06/17 14:00:29]

I've modified the comments here to make them make more sense, and described in
the histogram summary what the suffixes do.

+  <suffix name="MenuActions"/>
+  <suffix name="NTPLinkActions"/>
+  <suffix name="OneClickActions"/>
+  <suffix name="SettingsActions"/>
+  <suffix name="StartPageActions"/>
+  <suffix name="WebstoreInstallActions"/>

[Alexei Svitkine (slow), 2014/06/16 17:52:44]

How about UnknownActions?

[Mike Lerman, 2014/06/17 14:00:29]

Added.

+  <affected-histogram name="Signin"/>

[Alexei Svitkine (slow), 2014/06/16 17:35:24]

Change this to Signin.Actions.

[Mike Lerman, 2014/06/16 17:41:59]

As above.

+</histogram_suffixes>
+
 <histogram_suffixes name="Signin.Reconciler" separator=".">
   <suffix name="FirstRun"
       label="First execution of the reconciler after the profile was loaded