Navigation transitions: Initiate navigation transition and send serialized markup to Chrome

public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 162 matching lines @@
     // The client should handle the navigation externally.
     virtual void loadURLExternally(
         WebLocalFrame*, const WebURLRequest&, WebNavigationPolicy, const WebString& downloadName) { }
 
 
     // Navigational queries ------------------------------------------------
 
     // The client may choose to alter the navigation policy.  Otherwise,
     // defaultPolicy should just be returned.
     virtual WebNavigationPolicy decidePolicyForNavigation(
+        WebLocalFrame* frame, WebDataSource::ExtraData* extraData, const WebURLRequest& urlRequest, WebNavigationType navigationType,
+        WebNavigationPolicy defaultPolicy, bool isRedirect, bool isTransitionNavigation)
+    {
+        return decidePolicyForNavigation(frame, extraData, urlRequest, navigationType, defaultPolicy, isRedirect);
+    }
+
+    // DEPRECATED
+    virtual WebNavigationPolicy decidePolicyForNavigation(
         WebLocalFrame*, WebDataSource::ExtraData*, const WebURLRequest&, WebNavigationType,
         WebNavigationPolicy defaultPolicy, bool isRedirect) { return defaultPolicy; }

[abarth-chromium, 2014/06/13 17:18:31]

This sort of change is begging for a struct instead of a long list of changing
parameters.  Using a struct will also make it easier to add and remove
parameters in the future.

[oystein (OOO til 10th of July), 2014/06/18 00:04:09]

Done! I made the URL the only constructor parameter; seemed to make the most
semantic sense, but I can add all of them if need be.

 
     // During a history navigation, we may choose to load new subframes from history as well.
     // This returns such a history item if appropriate.
     virtual WebHistoryItem historyItemForNewChildFrame(WebFrame*) { return WebHistoryItem(); }
 
 
     // Navigational notifications ------------------------------------------
 
     // These notifications bracket any loading that occurs in the WebFrame.
     virtual void didStartLoading(bool toDifferentDocument) { }
     virtual void didStopLoading() { }
 
     // Notification that some progress was made loading the current frame.
     // loadProgress is a value between 0 (nothing loaded) and 1.0 (frame fully
     // loaded).
     virtual void didChangeLoadProgress(double loadProgress) { }
 
     // A form submission has been requested, but the page's submit event handler
     // hasn't yet had a chance to run (and possibly alter/interrupt the submit.)
     virtual void willSendSubmitEvent(WebLocalFrame*, const WebFormElement&) { }
 
     // A form submission is about to occur.
     virtual void willSubmitForm(WebLocalFrame*, const WebFormElement&) { }
 
     // A datasource has been created for a new navigation.  The given
     // datasource will become the provisional datasource for the frame.
     virtual void didCreateDataSource(WebLocalFrame*, WebDataSource*) { }
 
     // A new provisional load has been started.
+    virtual void didStartProvisionalLoad(WebLocalFrame* localFrame, bool isTransitionNavigation) { didStartProvisionalLoad(localFrame); }
+    // DEPRECATED
     virtual void didStartProvisionalLoad(WebLocalFrame*) { }
 
     // The provisional load was redirected via a HTTP 3xx response.
     virtual void didReceiveServerRedirectForProvisionalLoad(WebLocalFrame*) { }
 
     // The provisional load failed.
     virtual void didFailProvisionalLoad(WebLocalFrame*, const WebURLError&) { }
 
     // The provisional datasource is now committed.  The first part of the
     // response body has been received, and the encoding of the response
@@ skipping 274 matching lines @@
     // Send initial drawing parameters to a child frame that is being rendered out of process.
     virtual void initializeChildFrame(const WebRect& frameRect, float scaleFactor) { }
 
 protected:
     ~WebFrameClient() { }
 };
 
 } // namespace blink
 
 #endif