Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 319573002: Ignore out-of-order DTLS ChangeCipherSpec. (Closed)

Created:
6 years, 6 months ago by wtc
Modified:
6 years, 6 months ago
Reviewers:
ekr, agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Ignore out-of-order DTLS ChangeCipherSpec. Apply Eric Rescorla's patch from upstream NSS: https://bugzilla.mozilla.org/show_bug.cgi?id=1009227 R=agl@chromium.org,ekr@rtfm.com BUG=369855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M net/third_party/nss/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/ignorechangecipherspec.patch View 1 chunk +19 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
6 years, 6 months ago (2014-06-04 19:33:05 UTC) #1
agl
LGTM. I don't know DTLS well, but http://tools.ietf.org/html/rfc4347#section-4.2.4 seems to suggest the ignoring the CCS ...
6 years, 6 months ago (2014-06-05 23:47:01 UTC) #2
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-05 23:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/319573002/1
6 years, 6 months ago (2014-06-05 23:56:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 04:42:51 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:54:23 UTC) #6
Message was sent while issue was closed.
Change committed as 275389

Powered by Google App Engine
This is Rietveld 408576698