chrome/renderer/chrome_content_renderer_client.cc - Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated so that the yellow thing occurs only when the content setting is set to allow Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index f3e2313a696a00493874c8ab7fc1bfde197fc016..1cef128b3b9bd1037aa9accf6a41d2cb2f0c136b 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -814,6 +814,8 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(

render_frame->GetRoutingID(),

group_name,

identifier));

+ // Send IPC for showing content_setting_image/bubble.

+ observer->DidBlockContentType(content_type);

break;

}

case ChromeViewHostMsg_GetPluginInfo_Status::kClickToPlay: {

« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | no next file » | no next file with comments »