Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
index 2ce12166404868e231e642592c2a46272aebb01b..f543ef5dbc1496023a2c0acf92862ea4be72b73e 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
@@ -87,6 +87,7 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
bool custom_link_enabled;
std::string manage_link;
MediaMenuMap media_menus;
+ std::string learn_more_link;
private:
DISALLOW_COPY_AND_ASSIGN(BubbleContent);
@@ -113,6 +114,7 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
virtual void OnPopupClicked(int index) {}
virtual void OnCustomLinkClicked() {}
virtual void OnManageLinkClicked() {}
+ virtual void OnLearnMoreLinkClicked() {}
virtual void OnMediaMenuClicked(content::MediaStreamType type,
const std::string& selected_device_id) {}
@@ -151,6 +153,9 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
void set_manage_link(const std::string& link) {
bubble_content_.manage_link = link;
}
+ void set_learn_more_link(const std::string& link) {
+ bubble_content_.learn_more_link = link;
+ }
void add_media_menu(content::MediaStreamType type, const MediaMenu& menu) {
bubble_content_.media_menus[type] = menu;
}
@@ -190,7 +195,11 @@ class ContentSettingTitleAndLinkModel : public ContentSettingBubbleModel {
private:
void SetTitle();
void SetManageLink();
+ void SetLearnMoreLink();
+
+ // content::ContentSettingBubbleModel:
virtual void OnManageLinkClicked() OVERRIDE;
+ virtual void OnLearnMoreLinkClicked() OVERRIDE;
Delegate* delegate_;
};

Powered by Google App Engine
This is Rietveld 408576698