chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc - Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed the comment line Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_content_setting_bubble_model_delegate.h ('k') | chrome/browser/ui/content_settings/content_setting_bubble_model.h » ('j') | chrome/browser/ui/content_settings/content_setting_bubble_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

diff --git a/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc b/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

index 8a1c02309c9c70dea4010ab6a9be42161b700a10..3831dcddfd02cf000b3748eed29395a360b0a800 100644

--- a/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

+++ b/chrome/browser/ui/browser_content_setting_bubble_model_delegate.cc

@@ -48,3 +48,15 @@ void BrowserContentSettingBubbleModelDelegate::ShowContentSettingsPage(

return;

}

+void BrowserContentSettingBubbleModelDelegate::ShowLearnMorePage(

+ ContentSettingsType type) {

+ if (type != CONTENT_SETTINGS_TYPE_PLUGINS)

+ return;

+ chrome::AddSelectedTabWithURL(

+ browser_,

+ google_util::AppendGoogleLocaleParam(

+ GURL(chrome::kBlockedPluginLearnMoreURL)),

+ content::PAGE_TRANSITION_LINK);

+ return;

sky 2014/06/12 20:00:33 nit: no return.

radhikabhar 2014/06/12 20:37:19 Done.