Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6607)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed indentation and style issues Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
index 22fb503479298b74d00af4fc64395aa23057621a..b6b88fc5f7e0f1ae78ebd9076fc63627c6762d44 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
@@ -456,10 +456,28 @@ TEST_F(ContentSettingBubbleModelTest, Plugins) {
const ContentSettingBubbleModel::BubbleContent& bubble_content =
content_setting_bubble_model->bubble_content();
EXPECT_FALSE(bubble_content.title.empty());
- EXPECT_EQ(2U, bubble_content.radio_group.radio_items.size());
- EXPECT_FALSE(bubble_content.custom_link.empty());
- EXPECT_TRUE(bubble_content.custom_link_enabled);
+ EXPECT_FALSE(bubble_content.learn_more_link.empty());
+ EXPECT_EQ(3U, bubble_content.radio_group.radio_items.size());
+ EXPECT_TRUE(bubble_content.custom_link.empty());
+ // TODO(cthomp): We no longer use custom link for plugins, so remove test?
+ // EXPECT_TRUE(bubble_content.custom_link_enabled);
Chris Thompson 2014/06/06 18:38:06 I think compilation is failing because the macro i
EXPECT_FALSE(bubble_content.manage_link.empty());
+
+ //Radio button tests
+ content_setting_bubble_model.OnRadioClicked(0) {
+ EXPECT_EQ(CONTENT_SETTING_ALLOW,
+ content_settings->plugin_bubble_setting());
+ }
+
+ content_setting_bubble_model.OnRadioClicked(1) {
+ EXPECT_EQ(CONTENT_SETTING_DEFAULT,
+ content_settings->plugin_bubble_setting());
+ }
+
+ content_setting_bubble_model.OnRadioClicked(2) {
+ EXPECT_EQ(CONTENT_SETTING_BLOCK,
+ content_settings->plugin_bubble_setting());
+ }
}
TEST_F(ContentSettingBubbleModelTest, PepperBroker) {

Powered by Google App Engine
This is Rietveld 408576698