Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing

chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
@@ skipping 438 matching lines @@
       TabSpecificContentSettings::FromWebContents(web_contents());
   content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS);
 
   scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(
       ContentSettingBubbleModel::CreateContentSettingBubbleModel(
          NULL, web_contents(), profile(),
          CONTENT_SETTINGS_TYPE_PLUGINS));
   const ContentSettingBubbleModel::BubbleContent& bubble_content =
       content_setting_bubble_model->bubble_content();
   EXPECT_FALSE(bubble_content.title.empty());
-  EXPECT_EQ(2U, bubble_content.radio_group.radio_items.size());
-  EXPECT_FALSE(bubble_content.custom_link.empty());
-  EXPECT_TRUE(bubble_content.custom_link_enabled);
+  EXPECT_FALSE(bubble_content.learn_more_link.empty());
+  EXPECT_EQ(3U, bubble_content.radio_group.radio_items.size());
+  EXPECT_TRUE(bubble_content.custom_link.empty());
+  // TODO(cthomp): We no longer use custom link for plugins, so remove test?

[felt, 2014/06/11 02:37:30]

Another TODO here, can you delete the commented out code?

[radhikabhar, 2014/06/11 17:31:46]

Done.

+  // EXPECT_TRUE(bubble_content.custom_link_enabled);
   EXPECT_FALSE(bubble_content.manage_link.empty());
+
+  //Test to see that the default radio item is set to Block

[felt, 2014/06/11 02:37:30]

Missing a space:
// Test to ...

[radhikabhar, 2014/06/11 17:31:46]

Done.

+  EXPECT_EQ(2, bubble_content.radio_group.default_item);
+}
+
+TEST_F(ContentSettingBubbleModelTest, BlockedPluginsPermissionChange) {
+  TabSpecificContentSettings* content_settings =
+  TabSpecificContentSettings::FromWebContents(web_contents());

[felt, 2014/06/11 02:37:30]

indent line 472 by 4 more spaces

[radhikabhar, 2014/06/11 17:31:46]

Done.

+  std::string file_url("file:///plugin/quicktime.html");
+  NavigateAndCommit(GURL(file_url));
+  content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_PLUGINS);
+  {
+    scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(
+        ContentSettingBubbleModel::CreateContentSettingBubbleModel(
+            NULL, web_contents(), profile(),
+               CONTENT_SETTINGS_TYPE_PLUGINS));
+  }
+
+  EXPECT_EQ(CONTENT_SETTING_BLOCK,
+            content_settings->plugin_bubble_setting());
+
+  {
+    scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(
+       ContentSettingBubbleModel::CreateContentSettingBubbleModel(
+           NULL, web_contents(), profile(),
+               CONTENT_SETTINGS_TYPE_PLUGINS));
+    // Change the radio setting
+    content_setting_bubble_model->OnRadioClicked(0);
+  }
+
+  EXPECT_EQ(CONTENT_SETTING_ALLOW,
+            content_settings->plugin_bubble_setting());
+
+  {
+    scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(
+       ContentSettingBubbleModel::CreateContentSettingBubbleModel(
+           NULL, web_contents(), profile(),
+               CONTENT_SETTINGS_TYPE_PLUGINS));
+    // Change the radio setting
+    content_setting_bubble_model->OnRadioClicked(1);
+  }
+
+  EXPECT_EQ(CONTENT_SETTING_DEFAULT,
+            content_settings->plugin_bubble_setting());
 }
 
 TEST_F(ContentSettingBubbleModelTest, PepperBroker) {
   TabSpecificContentSettings* content_settings =
       TabSpecificContentSettings::FromWebContents(web_contents());
   content_settings->OnContentBlocked(CONTENT_SETTINGS_TYPE_PPAPI_BROKER);
 
   scoped_ptr<ContentSettingBubbleModel> content_setting_bubble_model(
       ContentSettingBubbleModel::CreateContentSettingBubbleModel(
          NULL, web_contents(), profile(),
@@ skipping 187 matching lines @@
   {
     ProtocolHandler handler = registry.GetHandlerFor("mailto");
     ASSERT_FALSE(handler.IsEmpty());
     EXPECT_EQ(CONTENT_SETTING_ALLOW,
               content_settings->pending_protocol_handler_setting());
     EXPECT_FALSE(registry.IsIgnored(test_handler));
   }
 
   registry.Shutdown();
 }