Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 319553005: [fsp] Make the selection state of providing extension icons prettier. (Closed)

Created:
6 years, 6 months ago by mtomasz
Modified:
6 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

[fsp] Make the selection state of providing extension icons prettier. This simple patch makes the selected icons look good on the dark blue selection background. Also, it is less tricky. TEST=Tested manually with multiple icons. BUG=375020 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275414

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_types.css View 1 chunk +1 line, -3 lines 3 comments Download

Messages

Total messages: 8 (0 generated)
mtomasz
@hirono: PTAL at this trivial patch. Thanks.
6 years, 6 months ago (2014-06-05 09:39:26 UTC) #1
hirono
https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css File ui/file_manager/file_manager/foreground/css/file_types.css (right): https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css#newcode513 ui/file_manager/file_manager/foreground/css/file_types.css:513: -webkit-filter: invert(100%) grayscale(100%) brightness(200%); How about: "brightness(0) invert();" ?
6 years, 6 months ago (2014-06-05 10:00:27 UTC) #2
mtomasz
https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css File ui/file_manager/file_manager/foreground/css/file_types.css (right): https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css#newcode513 ui/file_manager/file_manager/foreground/css/file_types.css:513: -webkit-filter: invert(100%) grayscale(100%) brightness(200%); On 2014/06/05 10:00:27, hirono wrote: ...
6 years, 6 months ago (2014-06-06 00:30:40 UTC) #3
hirono
https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css File ui/file_manager/file_manager/foreground/css/file_types.css (right): https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css#newcode513 ui/file_manager/file_manager/foreground/css/file_types.css:513: -webkit-filter: invert(100%) grayscale(100%) brightness(200%); On 2014/06/06 00:30:40, mtomasz wrote: ...
6 years, 6 months ago (2014-06-06 04:25:59 UTC) #4
mtomasz
On 2014/06/06 04:25:59, hirono wrote: > https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css > File ui/file_manager/file_manager/foreground/css/file_types.css (right): > > https://codereview.chromium.org/319553005/diff/1/ui/file_manager/file_manager/foreground/css/file_types.css#newcode513 > ...
6 years, 6 months ago (2014-06-06 04:26:20 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-06-06 04:26:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/319553005/1
6 years, 6 months ago (2014-06-06 04:27:41 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 11:43:15 UTC) #8
Message was sent while issue was closed.
Change committed as 275414

Powered by Google App Engine
This is Rietveld 408576698