Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 319553002: Removing reinterpret_cast<std::vector<...> > in RenderWidgetHostViewAura::SetCompositionText(). (Closed)

Created:
6 years, 6 months ago by huangs
Modified:
6 years, 6 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Removing reinterpret_cast<std::vector<...> > in RenderWidgetHostViewAura::SetCompositionText(). RenderWidgetHostViewAura::SetCompositionText() used reinterpret_cast<> to convert std::vector<ui::CompositionText> ==> std::vector<blink::WebCompositionUnderline> This requires ui::CompositionText (in Chrome) and blink::WebCompositionUnderline (in Blink) to be identical. This is problematic when we want to change blink::WebCompositionUnderline and blink::WebCompositionUnderline (and WebCore::CompositionUnderline), since Chrome & Blink CLs have to be separate. This CL implements manual copy to allow CL decoupling. BUG=135900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
huangs
OWNER review to rjkroege@. This is a prerequesite cleanup for IME bug fix.
6 years, 6 months ago (2014-06-04 18:13:13 UTC) #1
rjkroege
lgtm
6 years, 6 months ago (2014-06-04 18:37:55 UTC) #2
huangs
The CQ bit was checked by huangs@chromium.org
6 years, 6 months ago (2014-06-04 18:41:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/319553002/1
6 years, 6 months ago (2014-06-04 18:42:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 22:50:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 22:59:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10632)
6 years, 6 months ago (2014-06-04 22:59:01 UTC) #7
huangs
The CQ bit was checked by huangs@chromium.org
6 years, 6 months ago (2014-06-05 05:42:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/319553002/1
6 years, 6 months ago (2014-06-05 05:44:11 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 05:52:23 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 05:57:29 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10858)
6 years, 6 months ago (2014-06-05 05:57:29 UTC) #12
huangs
The CQ bit was checked by huangs@chromium.org
6 years, 6 months ago (2014-06-05 13:03:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/319553002/1
6 years, 6 months ago (2014-06-05 13:04:27 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 14:38:12 UTC) #15
Message was sent while issue was closed.
Change committed as 275103

Powered by Google App Engine
This is Rietveld 408576698