Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 319543006: Move c/b/e/api/api_resource_manager_unittest.cc to (Closed)

Created:
6 years, 6 months ago by limasdf
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move c/b/e/api/api_resource_manager_unittest.cc to src/extensions/browser/api/ Make it compiled and fix typo. BUG=381706 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275571

Patch Set 1 #

Patch Set 2 : use TestBrowserThreadBundle instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -75 lines) Patch
D chrome/browser/extensions/api/api_resource_manager_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + extensions/browser/api/api_resource_manager_unittest.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
limasdf
Devlin. It seems work. Please take a look Thanks as always!
6 years, 6 months ago (2014-06-06 18:57:13 UTC) #1
Devlin
lgtm
6 years, 6 months ago (2014-06-06 19:08:23 UTC) #2
limasdf
Added lei as the owner of /chrome
6 years, 6 months ago (2014-06-06 19:10:41 UTC) #3
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-06 19:14:29 UTC) #4
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 6 months ago (2014-06-06 19:14:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/319543006/20001
6 years, 6 months ago (2014-06-06 19:17:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 00:23:24 UTC) #7
Message was sent while issue was closed.
Change committed as 275571

Powered by Google App Engine
This is Rietveld 408576698