Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319543004: Move and rename FdopenPlatformFile to file_util (Closed)

Created:
6 years, 6 months ago by rvargas (doing something else)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Move and rename FdopenPlatformFile to file_util This CL also improves error handling and adds a unit test. BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275986

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -25 lines) Patch
M base/file_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/file_util_posix.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M base/file_util_win.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M base/platform_file.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/platform_file_posix.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/platform_file_win.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rvargas (doing something else)
PTAL
6 years, 6 months ago (2014-06-05 02:57:39 UTC) #1
rvargas (doing something else)
ping
6 years, 6 months ago (2014-06-06 21:29:51 UTC) #2
brettw
lgtm
6 years, 6 months ago (2014-06-09 17:15:16 UTC) #3
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-09 17:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/319543004/20001
6 years, 6 months ago (2014-06-09 17:52:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 09:00:15 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 11:19:55 UTC) #7
Message was sent while issue was closed. 
Change committed as 275986

Powered by Google App Engine
This is Rietveld 408576698