Issue 319533004: remove ashmem from skia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319533004: remove ashmem from skia (Closed)

Created:
6 years, 6 months ago by hal.canary

Modified:
6 years, 6 months ago

Reviewers:
scroggo, djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -285 lines)			Patch
M	gyp/images.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	gyp/ports.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gyp/utils.gyp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	src/ports/SkDiscardableMemory_ashmem.cpp	View	1 chunk	+0 lines, -128 lines	0 comments	Download
D	src/utils/android/ashmem.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	src/utils/android/ashmem.cpp	View	1 chunk	+0 lines, -95 lines	0 comments	Download

Total messages: 7 (0 generated)

hal.canary

On 2014/06/04 20:09:58, djsollen wrote: > did we have any ashmem specific tests? Nope. We ...

6 years, 6 months ago (2014-06-04 20:11:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/319533004/20001

6 years, 6 months ago (2014-06-05 14:53:51 UTC) #6

commit-bot: I haz the power

6 years, 6 months ago (2014-06-05 15:16:45 UTC) #7

Message was sent while issue was closed.

Change committed as 5ec3d217146dfd12bd4d0cde2fe25832fed5cad9