Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/metrics/proto/omnibox_input_type.proto

Issue 319523005: Omnibox: Combine Two Input Type Enums into One (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove blank line Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/proto/omnibox_input_type.proto
diff --git a/components/metrics/proto/omnibox_input_type.proto b/components/metrics/proto/omnibox_input_type.proto
new file mode 100644
index 0000000000000000000000000000000000000000..42a2b7a3cb38486ec0307baf068ba1f47b3a2ee0
--- /dev/null
+++ b/components/metrics/proto/omnibox_input_type.proto
@@ -0,0 +1,27 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Stores information about an omnibox interaction.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+
+package metrics.OmniboxInputType;
+
+// What kind of input the user provided.
+// Note that the type below may be misleading. For example, "http:/" alone
Mark P 2014/06/06 00:35:45 This "Note" came from AutocompleteInput::Type. Th
+// cannot be opened as a URL, so it is marked as a QUERY; yet the user
+// probably intends to type more and have it eventually become a URL, so we
+// need to make sure we still run it through inline autocomplete.
+enum Type {
+ INVALID = 0; // Empty input (should not reach here)
+ UNKNOWN = 1; // Valid input whose type cannot be determined
+ REQUESTED_URL = 2; // DEPRECATED. Input autodetected as UNKNOWN, which the
+ // user wants to treat as an URL by specifying a
+ // desired_tld
Ilya Sherman 2014/06/06 05:01:02 Hmm, it's a little awkward to expose this deprecat
Mark P 2014/06/06 20:22:51 Done. Because this longer enum name made it ugly
+ URL = 3; // Input autodetected as a URL
+ QUERY = 4; // Input autodetected as a query
+ FORCED_QUERY = 5; // Input forced to be a query by an initial '?'
+}

Powered by Google App Engine
This is Rietveld 408576698