Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 319523004: Outline notification implementation in server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index f90a9f1f6c0db52280fb0dfdcedb8e1916d2d65e..44d1f02fed4c6ee0eb681225c3c1c3b3b344853c 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -8,6 +8,7 @@ import 'package:analysis_server/src/operation/operation.dart';
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/computer/computer_highlights.dart';
import 'package:analysis_server/src/computer/computer_navigation.dart';
+import 'package:analysis_server/src/computer/computer_outline.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analyzer/src/generated/ast.dart';
@@ -76,6 +77,9 @@ class PerformAnalysisOperation extends ServerOperation {
if (server.hasAnalysisSubscription(AnalysisService.NAVIGATION, file)) {
sendAnalysisNotificationNavigation(server, file, dartUnit);
}
+ if (server.hasAnalysisSubscription(AnalysisService.OUTLINE, file)) {
+ sendAnalysisNotificationOutline(server, file, dartUnit);
+ }
}
if (!source.isInSystemLibrary) {
sendAnalysisNotificationErrors(server, file, notice.errors);
@@ -84,6 +88,7 @@ class PerformAnalysisOperation extends ServerOperation {
}
}
+
Brian Wilkerson 2014/06/04 23:54:00 I don't actually like having two blank lines betwe
scheglov 2014/06/05 01:37:51 Why not both? Two lines help to distinguish visua
void sendAnalysisNotificationErrors(AnalysisServer server,
String file, List<AnalysisError> errors) {
Notification notification = new Notification(NOTIFICATION_ERRORS);
@@ -92,6 +97,7 @@ void sendAnalysisNotificationErrors(AnalysisServer server,
server.sendNotification(notification);
}
+
void sendAnalysisNotificationHighlights(AnalysisServer server,
String file, CompilationUnit dartUnit) {
Notification notification = new Notification(NOTIFICATION_HIGHLIGHTS);
@@ -102,6 +108,7 @@ void sendAnalysisNotificationHighlights(AnalysisServer server,
server.sendNotification(notification);
}
+
void sendAnalysisNotificationNavigation(AnalysisServer server,
String file, CompilationUnit dartUnit) {
Notification notification = new Notification(NOTIFICATION_NAVIGATION);
@@ -112,6 +119,18 @@ void sendAnalysisNotificationNavigation(AnalysisServer server,
server.sendNotification(notification);
}
+
+void sendAnalysisNotificationOutline(AnalysisServer server,
+ String file, CompilationUnit dartUnit) {
+ Notification notification = new Notification(NOTIFICATION_OUTLINE);
+ notification.setParameter(FILE, file);
+ notification.setParameter(
+ OUTLINE,
+ new DartUnitOutlineComputer(dartUnit).compute());
+ server.sendNotification(notification);
+}
+
+
Map<String, Object> errorToJson(AnalysisError analysisError) {
// TODO(paulberry): move this function into the AnalysisError class.
ErrorCode errorCode = analysisError.errorCode;
« no previous file with comments | « pkg/analysis_server/lib/src/constants.dart ('k') | pkg/analysis_server/test/analysis_notification_outline_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698