Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319523003: Add bench for rectanizers (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleaned up #

Patch Set 3 : Actually use bench loops parameter #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -7 lines) Patch
A bench/RectanizerBench.cpp View 1 2 1 chunk +138 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M tests/GpuRectanizerTest.cpp View 1 2 chunks +7 lines, -7 lines 3 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-04 17:33:38 UTC) #1
robertphillips
6 years, 6 months ago (2014-06-05 11:59:00 UTC) #2
bsalomon
https://codereview.chromium.org/319523003/diff/40001/tests/GpuRectanizerTest.cpp File tests/GpuRectanizerTest.cpp (right): https://codereview.chromium.org/319523003/diff/40001/tests/GpuRectanizerTest.cpp#newcode62 tests/GpuRectanizerTest.cpp:62: SkTDArray<SkISize> rects; why this change?
6 years, 6 months ago (2014-06-05 14:02:00 UTC) #3
robertphillips
https://codereview.chromium.org/319523003/diff/40001/tests/GpuRectanizerTest.cpp File tests/GpuRectanizerTest.cpp (right): https://codereview.chromium.org/319523003/diff/40001/tests/GpuRectanizerTest.cpp#newcode62 tests/GpuRectanizerTest.cpp:62: SkTDArray<SkISize> rects; It is just a method variable not ...
6 years, 6 months ago (2014-06-05 14:07:06 UTC) #4
bsalomon
https://codereview.chromium.org/319523003/diff/40001/tests/GpuRectanizerTest.cpp File tests/GpuRectanizerTest.cpp (right): https://codereview.chromium.org/319523003/diff/40001/tests/GpuRectanizerTest.cpp#newcode62 tests/GpuRectanizerTest.cpp:62: SkTDArray<SkISize> rects; On 2014/06/05 14:07:06, robertphillips wrote: > It ...
6 years, 6 months ago (2014-06-05 14:07:46 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-05 14:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/319523003/40001
6 years, 6 months ago (2014-06-05 14:08:50 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 14:18:07 UTC) #8
Message was sent while issue was closed. 
Change committed as c2fce56522272c68c917e8f3d6a555cf21ec3161

Powered by Google App Engine
This is Rietveld 408576698