runtime/bin/eventhandler_win.cc - Issue 319503005: Don't issue new directory reads, if we already got unhandled data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_win.cc

Issue 319503005: Don't issue new directory reads, if we already got unhandled data. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_win.cc

diff --git a/runtime/bin/eventhandler_win.cc b/runtime/bin/eventhandler_win.cc

index 475a79e16e750ce3605b8b7e4761638e148b34ad..c16f1a50a1363d816d26ae9171407190a012b822 100644

--- a/runtime/bin/eventhandler_win.cc

+++ b/runtime/bin/eventhandler_win.cc

@@ -398,7 +398,7 @@ bool DirectoryWatchHandle::IssueRead() {

ScopedLock lock(this);

// It may have been started before, as we start the directory-handler when

// we create it.

- if (pending_read_ != NULL) return true;

+ if (pending_read_ != NULL || data_ready_ != NULL) return true;

OverlappedBuffer* buffer = OverlappedBuffer::AllocateReadBuffer(kBufferSize);

ASSERT(completion_port_ != INVALID_HANDLE_VALUE);

BOOL ok = ReadDirectoryChangesW(handle_,

« no previous file with comments | « no previous file | no next file » | no next file with comments »