Clean up Test's resourcePath code.

tests/Test.h

Index: tests/Test.h
diff --git a/tests/Test.h b/tests/Test.h
index 4d2cf2b6392349ed0751eb52274d3d219d27b7d9..e1d96b93b685489732e62490aac5fd4d76b497ca 100644
--- a/tests/Test.h
+++ b/tests/Test.h
@@ -62,8 +62,10 @@ namespace skiatest {
 
         static SkString GetTmpDir();
 
-        static void SetResourcePath(const char*);
-        static SkString GetResourcePath();
+        static void SetResourcePath(const char* resourcePath) {

[mtklein, 2014/06/05 12:55:33]

I wouldn't bother with the churn?  There's not going to be any benefit to
inlining these: SetResourcePath is called once, and GetResourcePath maybe 10
times?  This is a minor feature and it's nice to get it isolated and out of the
way in its own ignorable corner of the .cc file as much as possible.  We have to
pay 2 lines in here for SetResourcePath and GetResourcePath, and I'm happy to
pay a third for the extra clarity of scoping gResourcePath under Test, but I'd
like to stop there.

[tfarina, 2014/06/06 01:53:10]

Done.

+            gResourcePath = resourcePath;
+        }
+        static SkString& GetResourcePath() { return gResourcePath; }

[mtklein, 2014/06/05 12:55:33]

SkString is fine to return by value, especially here in a part of the code that
doesn't matter performance-wise.  I don't mind returning a const SkString&, but
it's inconsistent with GetTmpDir, and also forces us to be storing an SkString.

[tfarina, 2014/06/06 01:53:10]

Done.

 
         virtual bool isGPUTest() const { return false; }
         virtual void setGrContextFactory(GrContextFactory* factory) {}
@@ -73,6 +75,8 @@ namespace skiatest {
         virtual void onRun(Reporter*) = 0;
 
     private:
+        static SkString gResourcePath;

[mtklein, 2014/06/05 12:55:33]

Let's turn this back into a static const char*.  It's generally a good habit to
keep globals POD unless we're being particularly careful about their lifetimes.

[tfarina, 2014/06/06 01:53:10]

Done.

+
         Reporter*   fReporter;
         SkString    fName;
         bool        fPassed;