Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 319463002: Password bubble: Update the blacklisted-bubble text. (Closed)

Created:
6 years, 6 months ago by Mike West
Modified:
6 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Password bubble: Update the blacklisted-bubble text. This patch brings the password bubble text up to date with the latest UI proposal: Title: Passwords won't be saved Description: You chose not to allow passwords to be saved on this site. Buttons: Undo | Done Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275054

Patch Set 1 #

Patch Set 2 : New text. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Vaclav, mind taking a look? -mike
6 years, 6 months ago (2014-06-05 06:58:33 UTC) #1
vabr (Chromium)
LGTM
6 years, 6 months ago (2014-06-05 07:30:18 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 6 months ago (2014-06-05 07:31:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/319463002/20001
6 years, 6 months ago (2014-06-05 07:32:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 08:53:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 09:38:19 UTC) #6
Message was sent while issue was closed.
Change committed as 275054

Powered by Google App Engine
This is Rietveld 408576698