Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1873)

Issue 319383003: Revert of Initial ServiceWorker Cache API polyfill. (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
blink-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Revert of Initial ServiceWorker Cache API polyfill. (https://codereview.chromium.org/314133002/) Reason for revert: Triggering buffer overflow checks on Linux ASAN: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%20Tests%20%28sandboxed%29&number=2348 Original issue's description: > Initial ServiceWorker Cache API polyfill. > > A basic Cache API. No serialization of any kind, no testing, and no > add() method, as it depends on Fetch(). > > R=falken@chromium.org,jkarlin@chromium.org > TBR=jochen@chromium.org > BUG=374822 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175749 TBR=falken@chromium.org,jkarlin@chromium.org,jsbell@chromium.org,jochen@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=374822 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -143 lines) Patch
M Source/modules/modules.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
D Source/modules/serviceworkers/polyfills/cachePolyfill.js View 1 chunk +0 lines, -112 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Initial ServiceWorker Cache API polyfill.
6 years, 6 months ago (2014-06-07 22:59:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/319383003/1
6 years, 6 months ago (2014-06-07 22:59:18 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 22:59:36 UTC) #3
Message was sent while issue was closed.
Change committed as 175751

Powered by Google App Engine
This is Rietveld 408576698