Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2082)

Unified Diff: Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 319383002: Update comment now that I understand it better. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index d6adf3b1b7e895e72c1e88b9a6a894bd6b66bfc5..19144c8e9fd40402da84a84cb3f7eee5c49cc6b7 100644
--- a/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -448,8 +448,9 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
# This is so we remove lines for builders that skip this test, e.g. Android skips most
# tests and we don't want to leave stray [ Android ] lines in TestExpectations..
- # FIXME: Is this necessary at all now that _rebaseline_commands includes the builders that
- # used to be skipped because the result wasn't failing on tip of tree?
+ # This is only necessary for "webkit-patch rebaseline" and for rebaselining expected
+ # failures from garden-o-matic. rebaseline-expectations and auto-rebaseline will always
+ # pass the exact set of ports to rebaseline.
for port_name in self._tool.port_factory.all_port_names():
port = self._tool.port_factory.get(port_name)
generic_expectations = TestExpectations(port, tests=tests, include_overrides=False)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698