Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 319373002: Revert of Revert of Oilpan: Prepare to make ExecutionContext GarbageCollectedMixin. (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
CC:
blink-reviews, tzik, eae+blinkwatch, ericu+idb_chromium.org, dominicc+watchlist_chromium.org, dgrogan, kinuko+worker_chromium.org, rwlbuis, arv+blink, alecflett, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Mads Ager (chromium), sof, nhiroki, jsbell+idb_chromium.org, falken, cmumford, horo+watch_chromium.org, kouhei+heap_chromium.org, kinuko+fileapi
Visibility:
Public.

Description

Revert of Revert of Oilpan: Prepare to make ExecutionContext GarbageCollectedMixin. (https://codereview.chromium.org/319333002/) Reason for revert: This was an incorrect revert--this patch was not responsible for the crash. Original issue's description: > Revert of Oilpan: Prepare to make ExecutionContext GarbageCollectedMixin. (https://codereview.chromium.org/318023002/) > > Reason for revert: > plugins/document-open.html is crashing on debug layout bots > > Original issue's description: > > Oilpan: Prepare to make ExecutionContext GarbageCollectedMixin. > > > > We creates closures with ExecutionContexts in LocalFileSystem. The > > ExecutionContext needs to be a CrossThreadPersistent data member of > > closure. This CL adds ParamStorageTraits specialized to garbage-collected > > classes. > > > > This is a preparation to remove RefCounted from Node. > > > > BUG=357163 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175734 > > TBR=oilpan-reviews@chromium.org,haraken@chromium.org,tkent@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=357163 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175741 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,tkent@chromium.org NOTREECHECKS=true NOTRY=true BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -27 lines) Patch
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 4 chunks +9 lines, -2 lines 0 comments Download
M Source/core/dom/MainThreadTaskRunnerTest.cpp View 4 chunks +8 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileSystemCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/LocalFileSystem.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/LocalFileSystem.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLCallbackWrapper.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/heap/Handle.h View 2 chunks +31 lines, -0 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Revert of Oilpan: Prepare to make ExecutionContext GarbageCollectedMixin.
6 years, 6 months ago (2014-06-07 16:49:14 UTC) #1
haraken
LGTM, thanks for the gardening!
6 years, 6 months ago (2014-06-07 16:49:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/319373002/1
6 years, 6 months ago (2014-06-07 16:49:58 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 16:50:34 UTC) #4
Message was sent while issue was closed.
Change committed as 175747

Powered by Google App Engine
This is Rietveld 408576698